🌱 propagate ctx to retryWithExponentialBackoff in clusterctl #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/clusterctl
|
/hold for squash |
k8s-ci-robot
added
the
do-not-merge/hold
nojnhuh
force-pushed
the
clusterctl-ctx
branch
from
1779aec
to
3aa37b2
Compare
|
squashed! |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1656686d50a7976e532dbcef59189f90713c0cc9
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: In the spirit of of #8733, this PR adds a
context.Contextparameter to theretryWithExponentialBackoffhelper used throughout clusterctl. This allows backoff to short circuit if a context is canceled during a sleep between retries instead of only while the retried function is running. The primary change is to call apimachinery'swait.ExponentialBackoffWithContextinstead ofwait.ExponentialBackoff.Almost every call to this helper already had a context available, but there are a couple that needed
context.Background()s.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterctl