Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Update instructions checklist to generate release notes #9443

Merged
merged 1 commit into from
Oct 16, 2023
Merged

馃尡 Update instructions checklist to generate release notes #9443

merged 1 commit into from
Oct 16, 2023

Conversation

g-gaston
Copy link
Contributor

@g-gaston g-gaston commented Sep 15, 2023 •
edited

What this PR does / why we need it:
Update release tasks for release notes:

  • Add new instructions to build and use release notes tool.
  • Update manual edits and review steps required for the notes.
  • Make manual edits a checklist to be followed on the release day.

Part of #9104

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2023
furkatgofurov7
furkatgofurov7 reviewed Sep 16, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some nits, otherwise looks great

docs/release/release-tasks.md Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@furkatgofurov7
Copy link
Member

Related to: #9104

@furkatgofurov7 furkatgofurov7 mentioned this pull request Sep 16, 2023
Closed
35 tasks
furkatgofurov7
furkatgofurov7 reviewed Sep 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM pending squash, from my side.

killianmuldoon
killianmuldoon reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3585f8006d3d04e295a9297f621ee80174d2a0f5

furkatgofurov7
furkatgofurov7 reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

willie-yao
willie-yao approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

furkatgofurov7
furkatgofurov7 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit bc470bd into kubernetes-sigs:main Oct 16, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@willie-yao willie-yao willie-yao approved these changes

@mjlshen mjlshen Awaiting requested review from mjlshen

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPI v1.6 release improvement tasks
Status: Done
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@g-gaston @furkatgofurov7 @k8s-ci-robot @chrischdi @killianmuldoon @willie-yao