馃尡 Exclude release trigger PRs from release notes #9444
Conversation
k8s-ci-robot
added
area/release
k8s-ci-robot
added
the
size/S
| case strings.HasPrefix(entry.title, "馃殌"), strings.HasPrefix(entry.title, "馃尡 Release v1."): | ||
| // Release trigger PRs from previous releases are not included in the release notes | ||
| return nil, nil | ||
| case strings.HasPrefix(entry.title, ":seedling:"), strings.HasPrefix(entry.title, "馃尡"): |
There was a problem hiding this comment.
Can we add a TODO to remove this once it's no longer relevant? If I understand right it should be unnecessary after the coming releases for 1.4.X and 1.5.X
There was a problem hiding this comment.
I'll add a todo
We can remove it one we release 1.6
Until then, these two commits will show up in the notes for all beta and RC releases for 1.6 (since these read from main)
g-gaston
force-pushed
the
release-prs-release-notes-exclude
branch
from
d88ba85
to
2fb410e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 46bfb92fdcfb36b1e9052bba84574c28ed7e595b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
We now trigger the release process (branches, tags, github draft PR, etc.) by merging a PR in main containing the release notes in markdown file.
This changes exclude these "trigger" PRs from the release notes, since they are not really changes we are shipping. All future trigger PRs will start with 馃殌. We use "馃尡 Release v1." as a fallback since the are existing PRs that didn't use the rocket emoji because they were created before we came up with the 馃殌 idea.
Which issue(s) this PR fixes
Part of #9104
/area release