馃尡 Move docker infrastructure API v1beta1 webhooks to separate package #9458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/api
Ankitasw
changed the title
|
/test pull-cluster-api-e2e-full-main |
25 tasks
sbueringer
reviewed
Sep 19, 2023
test/infrastructure/docker/internal/webhooks/dockercluster_webhook.go
Outdated
Show resolved
Hide resolved
test/infrastructure/docker/internal/webhooks/dockercluster_webhook.go
Outdated
Show resolved
Hide resolved
test/infrastructure/docker/internal/webhooks/dockerclustertemplate_webhook.go
Outdated
Show resolved
Hide resolved
test/infrastructure/docker/internal/webhooks/dockerclustertemplate_webhook.go
Outdated
Show resolved
Hide resolved
test/infrastructure/docker/internal/webhooks/dockermachinetemplate_webhook.go
Outdated
Show resolved
Hide resolved
|
Overall looks good. Basically just one finding + we can make some improvements to our Makefile to detect if the manifests.yaml is still generated (it wasn't regenerated in this PR because the files were moved and the new package was not added to the generate target) |
Ankitasw
force-pushed
the
move-docker-api-webhooks
branch
from
189393b
to
57ccff7
Compare
k8s-ci-robot
added
size/L
Ankitasw
force-pushed
the
move-docker-api-webhooks
branch
from
57ccff7
to
19b6a71
Compare
sbueringer
reviewed
Sep 19, 2023
Ankitasw
force-pushed
the
move-docker-api-webhooks
branch
2 times, most recently
from
a7a1249
to
9490cea
Compare
sbueringer
changed the title
sbueringer
reviewed
Sep 19, 2023
Ankitasw
force-pushed
the
move-docker-api-webhooks
branch
from
9490cea
to
a0ec023
Compare
|
Thank youuu! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6b865c160d5e09600e4ae194faa7dfce2146d85a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To work towards #9011, we need to remove the reliance on controller-runtime from the API packages.
This updates the webhooks to use the CustomDefaulter and CustomValidator pattern and moves them to match the Cluster and ClusterClass webhooks. This Is a more major lift but removes quite a bit of the code from the API package itself, making it's reliance on controller-runtime a lot smaller.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
/area api