📖 Change kubernetes-version in ignition/cluster generation parts of the book

[odvarkadaniel]

What this PR does / why we need it:

Currently, there is an incorrect version of kubernetes-version flag in the docs for the ignition part as the version that is currently used in the book does not have an AMI for this version.
I also changed all the occurences of kubernetes-version that does not reflect the newest stable release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9402

/area docs

[k8s-ci-robot]

@odvarkadaniel: The label(s) area/docs cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Currently, there is an incorrect version of kubernetes-version flag in the docs for the ignition part as the version that is currently used in the book does not have an AMI for this version.
I also changed all the occurences of kubernetes-version that does not reflect the newest stable release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9402

/area docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @odvarkadaniel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[odvarkadaniel]

/area documentation

What do you think about introducing for ignition command something like this:

--kubernetes-version $(curl -Ls https://dl.k8s.io/release/stable.txt | awk -F. '{$NF=0}1' OFS=.)

I don't know whether it is guaranteed that there is an AMI for every newest version or when does that happen, but this command would make sure we are not always behind that much and that the AMI actually exists for the version.

[killianmuldoon]

What do you think about introducing for ignition command something like this:

IMO it might be better to add a note with a link where folks can find out what images are available and changing the ignition docs to be explicitly an example.

I'm not sure if introducing automatic version resolution that's sometimes broken is better than having this be updated infrequently and periodically becoming broken. I think the real solution here would be to have more active maintenance of these docs.

/ok-to-test
/area documentation

[sbueringer]

/lgtm

I'm fine with updating the Kubernetes versions manually. I wouldn't add any automation / magic. We have no way to tell if all infra providers work with these Kubernetes versions anyway (CAPA is just one case, but there are a lot more infra providers out there).

I think the core CAPI book can just provide some examples here, but it cannot guarantee that it works with every infra provider. Providing valid and tested Kubernetes versions should be up to the infra provider and their documentation.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d7c844c313829a6446f53160fc1f37e21341a135

[odvarkadaniel]

Thank you for your input! I have also added a note regarding the availability of AMIs.

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6c9a3da128aa7d9e56a49d1f2cda0376640523d3

[killianmuldoon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• docs/OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/cherry-pick release-1.5

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #9466

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.