-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 Fix some nits in Cluster topology engine tests #9464
馃尡 Fix some nits in Cluster topology engine tests #9464
Conversation
/hold until #9373 is merged and this PR rebased |
c23f0ea
to
5fd8f3d
Compare
/hold cancel /assign @killianmuldoon @chrischdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 122e4b4899c8c3a98ff4ab6701ce6215b3876147
|
Merging given the changes are super trivial + the lgtm above /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Some minor fixes as follow-up to #9373
I would have pushed a commit to #9373 directly, but I didn't have the permissions
(Johannes is on PTO and we decided that I take over his PR's while he's away)