Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Add MachinePool test cases #9474

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 20, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Supersedes #9371

Pushed the fixes as a separate commit, will squash before merge.

(I unfortunately can't push onto #9371, I talked to Johannes that I"ll finish up his PRs while he's on PTO)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2023
@sbueringer sbueringer force-pushed the pr-cc-mp-inline-patches-test-fixup branch from ec09673 to 0bd35b0 Compare September 20, 2023 18:41
@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Sep 20, 2023
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 495057353c47d14094cf5b5f0190e09adfd68386

@sbueringer sbueringer force-pushed the pr-cc-mp-inline-patches-test-fixup branch from 0bd35b0 to 406c8b5 Compare September 21, 2023 07:30
@sbueringer
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2f9c7bd into kubernetes-sigs:main Sep 21, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Sep 21, 2023
@sbueringer sbueringer deleted the pr-cc-mp-inline-patches-test-fixup branch September 21, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants