📖 Add release task about removing unsupported release version of CAPI #9487
Conversation
k8s-ci-robot
added
kind/documentation
docs/release/release-tasks.md
Outdated
| @@ -120,6 +120,7 @@ This comes down to changing occurrences of the old version to the new version, e | |||
| Please note that both `InitWithKubernetesVersion` and `WorkloadKubernetesVersion` should be the highest mgmt cluster version supported by the respective Cluster API version. | |||
| 2. Update `create-local-repository.py` and `tools/internal/tilt-prepare/main.go`: `v1.4.99` => `v1.5.99`. | |||
| 3. Make sure all tests are green (also run `pull-cluster-api-e2e-full-main` and `pull-cluster-api-e2e-workload-upgrade-1-23-latest-main`). | |||
| 4. Remove unsupported release version of Cluster API. For example remove `v1.3` while working on `v1.6`. | |||
There was a problem hiding this comment.
This is already covered under L~546. Similar to #9486 is the idea here to move responsibility of this from the CI lead to the release lead?
There was a problem hiding this comment.
This needs to be checked with @furkatgofurov7, I will wait for his response as he is out on a vacation.
There was a problem hiding this comment.
This is already covered under L~546. Similar to #9486 is the idea here to move responsibility of this from the CI lead to the release lead?
@killianmuldoon this has to be under the RL responsibilities and part of the steps working on preparing the main branch work, as we need to remove makefile target to generate e2e templates for unsupported release branch. Maybe we could clarify it a bit in the notes if that was not clear?
There was a problem hiding this comment.
I definitely think clarifying this is a good idea. This is the line in the CI tasks I was talking about:
Remove tests for old release branches according to our policy documented in Support and guarantees For example, let's assume we just created tests for v1.4, then we can now drop test coverage for the release-1.1 branch.
Maybe that should be clarified to only refer to the test-infra test config?
There was a problem hiding this comment.
Maybe that should be clarified to only refer to the test-infra test config?
Agree, it has 2 parts: changes needed in CAPI code base & test-infra repo, and above line refers to the latter. In that case, we could:
- leave the current notes in this PR where it is now but clarify that the Makefile target for the old branch has to be removed
- clarify the notes from CI tasks that it only refers to the test-infra repo changes
WDYT?
There was a problem hiding this comment.
@chiukapoor can you please update the PR accordingly?
docs/release/release-tasks.md
Outdated
| @@ -120,6 +120,7 @@ This comes down to changing occurrences of the old version to the new version, e | |||
| Please note that both `InitWithKubernetesVersion` and `WorkloadKubernetesVersion` should be the highest mgmt cluster version supported by the respective Cluster API version. | |||
| 2. Update `create-local-repository.py` and `tools/internal/tilt-prepare/main.go`: `v1.4.99` => `v1.5.99`. | |||
| 3. Make sure all tests are green (also run `pull-cluster-api-e2e-full-main` and `pull-cluster-api-e2e-workload-upgrade-1-23-latest-main`). | |||
| 4. Remove unsupported release version of Cluster API. For example remove `v1.3` while working on `v1.6`. | |||
There was a problem hiding this comment.
| 4. Remove unsupported release version of Cluster API. For example remove `v1.3` while working on `v1.6`. | |
| 4. Remove an unsupported release version of Cluster API from the Makefile target that generates e2e templates. For example, remove `v1.3` while working on `v1.6`. |
There was a problem hiding this comment.
@chiukapoor we also need to change notes for CI manager tasks from:
Remove tests for old release branches according to our policy documented in [Support and guarantees](https://github.com/chiukapoor/cluster-api/blob/issue-9485/CONTRIBUTING.md#support-and-guarantees) For example, let's assume we just created tests for v1.4, then we can now drop test coverage for the release-1.1 branch.
to:
Remove tests from the test-infra repository for old release branches according to our policy documented in [Support and guarantees](https://github.com/chiukapoor/cluster-api/blob/issue-9485/CONTRIBUTING.md#support-and-guarantees). For example, let's assume we just created tests for v1.4, then we can now drop test coverage for the release-1.1 branch.
There was a problem hiding this comment.
Inculcating the changes
… Update test removal task of CI team Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
chiukapoor
force-pushed
the
issue-9485
branch
from
6df3815
to
e4b1f7e
Compare
There was a problem hiding this comment.
Thanks @chiukapoor!
/approve
cc @killianmuldoon PTAL when you have time 🙂
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: aaaf4ca744c72f239e02ded708f36d5d93e747b5
|
Part of the Improvement tasks for the v1.6 release cycle #9104
What this PR does / why we need it:
Which issue(s) this PR fixes
Fixes #9485
/kind documentation
/area release