Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 ipam: add age column to kubectl output #9521

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This PR adds the AGE column to the output of kubectl for the IPAM resources IPAdressClaim and IPAddress.

Before:

❯ kubectl get ipaddressclaims,ipaddress
NAME                                             POOL NAME   POOL KIND
ipaddressclaim.ipam.cluster.x-k8s.io/foo-claim   foobar      bar

NAME                                     ADDRESS       POOL NAME   POOL KIND
ipaddress.ipam.cluster.x-k8s.io/foo-ip   192.168.0.2   foobar      bar

After:

❯ kubectl get ipaddressclaims,ipaddress
NAME                                             POOL NAME   POOL KIND   AGE
ipaddressclaim.ipam.cluster.x-k8s.io/foo-claim   foobar      bar         101s

NAME                                     ADDRESS       POOL NAME   POOL KIND   AGE
ipaddress.ipam.cluster.x-k8s.io/foo-ip   192.168.0.2   foobar      bar         8s

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area ipam

@k8s-ci-robot k8s-ci-robot added the area/ipam Issues or PRs related to ipam label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c9645ecba301af77ca4ce9befd384b135b16a97

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7b21e0c into kubernetes-sigs:main Oct 4, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 4, 2023
@chrischdi chrischdi deleted the pr-ipam-age-column branch October 4, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipam Issues or PRs related to ipam cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants