Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ promote IPAM types to v1beta1 #9525

Merged
merged 2 commits into from
Oct 11, 2023
Merged

✨ promote IPAM types to v1beta1 #9525

merged 2 commits into from
Oct 11, 2023

Conversation

rvanderp3
Copy link
Contributor

What this PR does / why we need it:
Promotes IPAM types to v1beta1.

Which issue(s) this PR fixes:
Fixes #8694

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rvanderp3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2023
@rvanderp3
Copy link
Contributor Author

/area ipam

@k8s-ci-robot k8s-ci-robot added area/ipam Issues or PRs related to ipam and removed do-not-merge/needs-area PR is missing an area label labels Oct 4, 2023
killianmuldoon
killianmuldoon reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2023
@rvanderp3
Copy link
Contributor Author

/hold

placing hold while test failures are reviewed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@vincepri
Copy link
Member

vincepri commented Oct 4, 2023

@rvanderp3 We should add the conversion webhooks as part of this PR, feel free to reach out if you have questions

@rvanderp3
Copy link
Contributor Author

@rvanderp3 We should add the conversion webhooks as part of this PR, feel free to reach out if you have questions

Sure thing, thanks!

@rvanderp3 rvanderp3 force-pushed the ISSUE-8694 branch 2 times, most recently from 9396eee to b3b062a Compare October 5, 2023 19:30
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2023
@rvanderp3 rvanderp3 force-pushed the ISSUE-8694 branch 6 times, most recently from 07bfbff to 51dba3d Compare October 5, 2023 22:44
@rvanderp3
Copy link
Contributor Author

/test pull-cluster-api-test-main

@rvanderp3
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@rvanderp3
Copy link
Contributor Author

/assign @vincepri

@vincepri this is ready for review. would you mind taking a look when you get a chance?

@killianmuldoon
Copy link
Contributor

/hold

Just want to make sure this gets review from the right folks before its merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@rvanderp3
Copy link
Contributor Author

/assign @schrej @tylerschultz @vincepri

@k8s-ci-robot
Copy link
Contributor

@rvanderp3: GitHub didn't allow me to assign the following users: tylerschultz.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @schrej @tylerschultz @vincepri

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

schrej
schrej reviewed Oct 10, 2023
View reviewed changes
exp/ipam/api/v1alpha1/conversion.go Outdated
return err
}

return utilconversion.MarshalData(src, dst)
Copy link
Member

@schrej schrej Oct 10, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to call MarshalData here if we aren't using it when converting back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we do not. i just removed it.

@rvanderp3
Copy link
Contributor Author

/test pull-cluster-api-test-main

there seems to be a flake, i'll investigate and open an issue on this

@schrej
Copy link
Member

schrej commented Oct 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95eb99b6d225168bbc9dc38568d8e5471ff0d677

@rvanderp3
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2023
vincepri
vincepri approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ffa1ed into kubernetes-sigs:main Oct 11, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 11, 2023
@rvanderp3 rvanderp3 mentioned this pull request Nov 2, 2023
Closed
9 tasks
This was referenced Apr 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrej schrej schrej left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@vincepri vincepri vincepri approved these changes

@richardcase richardcase Awaiting requested review from richardcase

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@schrej schrej

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipam Issues or PRs related to ipam cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Consider moving IPAM provider out of experimental
5 participants
@rvanderp3 @k8s-ci-robot @vincepri @killianmuldoon @schrej