Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Update kubebuilder-release-tools to v0.4.0 #9531

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Oct 9, 2023

What this PR does / why we need it:
This will allow us to use the 馃殌 emoji to indicate PRs that will trigger a new release. Related to #9444 where we found that we needed kubernetes-sigs/kubebuilder-release-tools#55 in order to leverage the new process fully. It has since been released in v0.4.0 and this PR is just getting ahead of dependabot to make sure we can have this available before the next release.

Which issue(s) this PR fixes:
Part of #9104

/area release

This will allow us to use the 馃殌 emoji to indicate PRs that will
trigger a new release.

Signed-off-by: Michael Shen <mishen@umich.edu>
@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
@mjlshen
Copy link
Contributor Author

mjlshen commented Oct 9, 2023

cc @kubernetes-sigs/cluster-api-release-team once this PR is merged, the ability to use the 馃殌 emoji on release PRs should work for the next release

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbee44456a7247e610d83ee1799a0d7e8c6e91b3

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [killianmuldoon,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ce8209b into kubernetes-sigs:main Oct 9, 2023
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 9, 2023
@mjlshen mjlshen deleted the rocket-emoji branch October 9, 2023 22:33
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.5

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #9602

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #9603

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants