Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add WaitForMachinePoolToBeUpgraded to self-hosted test #9540

Merged
merged 1 commit into from
Nov 1, 2023
Merged

馃尡 Add WaitForMachinePoolToBeUpgraded to self-hosted test #9540

merged 1 commit into from
Nov 1, 2023

Conversation

willie-yao
Copy link
Contributor

What this PR does / why we need it:
This PR adds a missing field in the self-hosted test spec that may have been causing flakes in the self-hosted clusterclass spec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes (maybe) #9522

/area testing

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2023
@willie-yao
Copy link
Contributor Author

/test ls

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

@willie-yao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-scale-main-experimental

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@willie-yao willie-yao changed the title [WIP] [DO_NOT_MERGE] Add WaitForMachinePoolToBeUpgraded to Self-hosted test 馃尡 [WIP] [DO_NOT_MERGE] Add WaitForMachinePoolToBeUpgraded to Self-hosted test Oct 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@willie-yao
Copy link
Contributor Author

/retest

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2023
@willie-yao willie-yao changed the title 馃尡 [WIP] [DO_NOT_MERGE] Add WaitForMachinePoolToBeUpgraded to Self-hosted test 馃尡 Add WaitForMachinePoolToBeUpgraded to Self-hosted test Oct 12, 2023
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main
/assign @killianmuldoon

@willie-yao
Copy link
Contributor Author

/assign @nawazkh

nawazkh
nawazkh reviewed Oct 12, 2023
View reviewed changes
test/e2e/self_hosted.go
MachinePools: clusterResources.MachinePools,
KubernetesUpgradeVersion: input.E2EConfig.GetVariable(KubernetesVersionUpgradeTo),
WaitForMachinesToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
WaitForMachinePoolToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-pool-upgrade"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome change. Thanks!
@killianmuldoon

@nawazkh
Copy link
Member

nawazkh commented Oct 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6ad77c00295f16f7e122d0d8bf70e0b4d4f532c

@willie-yao
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor

/test pull-cluster-api-e2e-full-main

chrischdi
chrischdi reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

killianmuldoon
killianmuldoon reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@killianmuldoon killianmuldoon changed the title 馃尡 Add WaitForMachinePoolToBeUpgraded to Self-hosted test 馃尡 Add WaitForMachinePoolToBeUpgraded to Self-hosted test Nov 1, 2023
@killianmuldoon killianmuldoon changed the title 馃尡 Add WaitForMachinePoolToBeUpgraded to Self-hosted test 馃尡 Add WaitForMachinePoolToBeUpgraded to self-hosted test Nov 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit ded1cd7 into kubernetes-sigs:main Nov 1, 2023
48 of 50 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Nov 1, 2023
@sbueringer sbueringer mentioned this pull request Nov 15, 2023
Merged
@willie-yao willie-yao mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@nawazkh nawazkh nawazkh left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@chrischdi chrischdi

@nawazkh nawazkh

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@willie-yao @k8s-ci-robot @nawazkh @killianmuldoon @chrischdi