Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Dump all resource information for self-hosted tests #9547

Merged
merged 1 commit into from
Oct 13, 2023
Merged

馃尡 Dump all resource information for self-hosted tests #9547

merged 1 commit into from
Oct 13, 2023

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Oct 12, 2023 •
edited

What this PR does / why we need it:

  • The changes added in this PR will capture "destination clusters" nodes and pod info before they get cleaned.
  • These changes are added to self_hosted cluster tests.
  • Aiming to track down When testing Cluster API working on self-hosted clusters using ClusterClass with a HA control plane [ClusterClass]

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Oct 12, 2023

/cc @killianmuldoon @furkatgofurov7 @kranurag7 @willie-yao

@k8s-ci-robot
Copy link
Contributor

@nawazkh: GitHub didn't allow me to request PR reviews from the following users: kranurag7.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @killianmuldoon @furkatgofurov7 @kranurag7 @willie-yao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

Seems to be working as expected now!

From the last run: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9547/pull-cluster-api-e2e-main/1712503954639687680/artifacts/clusters/self-hosted-232puj/resources/

killianmuldoon
killianmuldoon reviewed Oct 12, 2023
View reviewed changes
test/e2e/common.go Outdated Show resolved Hide resolved
killianmuldoon
killianmuldoon reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - just a couple of cleanups and then it's good to merge.

test/e2e/common.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@nawazkh nawazkh changed the title [WIP]dump nodes and pod info before clearing it out dump all info about resources before clearing it out Oct 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Oct 12, 2023 •
edited

In an effort to fix #9522

@chrischdi
Copy link
Member

/retitle 馃尡 dump all resources information before clearing it out

@k8s-ci-robot k8s-ci-robot changed the title dump all info about resources before clearing it out 馃尡 dump all resources information before clearing it out Oct 13, 2023
@chrischdi
Copy link
Member

/retitle 馃尡 also dump all resource information before clearing it out for self-hosted tests

@k8s-ci-robot k8s-ci-robot changed the title 馃尡 dump all resources information before clearing it out 馃尡 also dump all resource information before clearing it out for self-hosted tests Oct 13, 2023
@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-scale-main-experimental

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

Should we run /test pull-cluster-api-e2e-full-main to see the result?

@killianmuldoon
Copy link
Contributor

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Copy link
Contributor

Looks like we got the flake on this PR 馃槃

https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9547/pull-cluster-api-e2e-full-main/1712770490558320640/artifacts/clusters/self-hosted-f94tib/resources/

I think we should merge this regardless as it's a positive change either way.

/retest

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9fab34edc8ec9fdff13917f307a0171092bc3653

@killianmuldoon
Copy link
Contributor

/approve

Assuming we don't fail the e2e run again 馃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@killianmuldoon
Copy link
Contributor

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Oct 13, 2023
@killianmuldoon killianmuldoon changed the title 馃尡 also dump all resource information before clearing it out for self-hosted tests 馃尡 Dump all resource information for self-hosted tests Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit efb0679 into kubernetes-sigs:main Oct 13, 2023
48 of 52 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 13, 2023
@nawazkh nawazkh deleted the self_hosted_clusterclass branch October 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@ykakarap ykakarap Awaiting requested review from ykakarap

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nawazkh @k8s-ci-robot @killianmuldoon @chrischdi