Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 Add In-place upgrades feature group #9559

Merged
merged 1 commit into from
Nov 2, 2023
Merged

馃摉 Add In-place upgrades feature group #9559

merged 1 commit into from
Nov 2, 2023

Conversation

g-gaston
Copy link
Contributor

What this PR does / why we need it:
As proposed in office hours, creating a working group to work together in a proposal.

Which issue(s) this PR fixes:
Starting with #9489

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2023
@mayur-tolexo
Copy link

I would like to be a part of this.

@fabriziopandini
Copy link
Member

/lgtm

Great to see this happening!
I personally think this is the right time for the project to look into this, looking forward to see this moving forward

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 646adff558c86a3b9f3ffdc80d8189bf85605eca

@fabriziopandini
Copy link
Member

/hold
for the meeting time to be added + give others time to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
killianmuldoon
killianmuldoon reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looking forward to seeing what comes from this work!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
furkatgofurov7
furkatgofurov7 reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

docs/community/20231016-in-place-upgrades.md Outdated Show resolved Hide resolved
@g-gaston
Copy link
Contributor Author

Meeting and google doc added, I think this is ready to go :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
furkatgofurov7
furkatgofurov7 suggested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few last nits we need to fix :)

docs/community/20231016-in-place-upgrades.md Show resolved Hide resolved
docs/community/20231016-in-place-upgrades.md Show resolved Hide resolved
docs/community/20231016-in-place-upgrades.md Outdated Show resolved Hide resolved
furkatgofurov7
furkatgofurov7 reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g-gaston!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d48938085138baa43181a832b340895ccad135d4

@Oats87
Copy link

Oats87 commented Oct 20, 2023

I would love to also be a part of this!

@g-gaston
Copy link
Contributor Author

I would love to also be a part of this!

We'll be meeting Wednesdays at 8am PST in https://zoom.us/j/861487554
Pls join us!

@Oats87
Copy link

Oats87 commented Oct 25, 2023

I would love to also be a part of this!

We'll be meeting Wednesdays at 8am PST in https://zoom.us/j/861487554 Pls join us!

Apologies for not joining. I was told "one hour before CAPI meeting" and had assumed it was at 9 AM PST rather than 8 AM PST.

I will do my best to join it next week!

@sbueringer
Copy link
Member

This seems fine to me. Should we merge @vincepri @fabriziopandini ?

/lgtm

@pshail
Copy link

pshail commented Nov 2, 2023

I also would love to be a part of this effort

@neolit123 neolit123 mentioned this pull request Nov 2, 2023
Closed
@g-gaston
Copy link
Contributor Author

g-gaston commented Nov 2, 2023

I also would love to be a part of this effort

We are meeting Wednesdays at 8am PST in https://zoom.us/j/861487554
Here are the meeting notes so you can track what we have discussed and if we cancel a meeting or whatelse: https://docs.google.com/document/d/1GmRd6MyQ0mWAoJV6rCHhZTSTtKMKHdJzhXm0BLBXOnw

Pls join us!

fabriziopandini
fabriziopandini reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Awesome folks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 34a990c into kubernetes-sigs:main Nov 2, 2023
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Nov 2, 2023
@Goend Goend mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmjit dharmjit dharmjit left review comments

@vincepri vincepri vincepri left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 requested changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@furkatgofurov7 furkatgofurov7

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet