Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Add onboarding documentation for the Release Team #9565

Merged

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Oct 18, 2023

What this PR does / why we need it:
This PR adds an initial version of the release Team onboarding documentation which should serve as a starting point of the onboarding notes based on my experience being involved in the RT and can be evolved over time with more notes as the release team continues to serve in the future.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9274

/area release
/kind documentation

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@furkatgofurov7
Copy link
Member Author

@kubernetes-sigs/cluster-api-release-team

/cc @killianmuldoon @fabriziopandini @CecileRobertMichon @chrischdi

docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
@g-gaston
Copy link
Contributor

Thanks @furkatgofurov7
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5de132946db4fe058a8eb3c702a191e62dfea635

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single nit,

we don't have that line in the other doctoc generated stuf.

As of that lgtm :-)

docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits - thanks for adding this!

docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
docs/release/release-team-onboarding.md Outdated Show resolved Hide resolved
@furkatgofurov7 furkatgofurov7 force-pushed the add-onboarding-tasks branch 2 times, most recently from d5081aa to 15f3ef9 Compare October 20, 2023 12:20
@furkatgofurov7
Copy link
Member Author

@killianmuldoon @chrischdi thanks for reviews, PTAL once again when you have some spare time.

docs/release/release-team.md Outdated Show resolved Hide resolved
docs/release/release-team.md Outdated Show resolved Hide resolved
@killianmuldoon
Copy link
Contributor

Last couple of nits

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Oct 25, 2023

@killianmuldoon thank you, pushed it as a new commit for easier review

Edit: messed up the new commit, force pushed the old commit with suggested changes.

@furkatgofurov7 furkatgofurov7 force-pushed the add-onboarding-tasks branch 2 times, most recently from fddb405 to 15f3ef9 Compare October 25, 2023 11:29
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Member Author

/test pull-cluster-api-test-main

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

Just in case you'd like a last round from the relevant teams.

Thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f063cbd960b4f5ff94d8f088c9422efc7625a7ed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@nawazkh
Copy link
Member

nawazkh commented Oct 25, 2023

/lgtm

@g-gaston
Copy link
Contributor

/lgtm

@furkatgofurov7
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7a55850 into kubernetes-sigs:main Oct 26, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 26, 2023
@sbueringer
Copy link
Member

Nice doc, thx!

@furkatgofurov7 furkatgofurov7 deleted the add-onboarding-tasks branch October 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Team: Add Release Team members onboarding documentation
7 participants