Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 add proposal for karpenter integration feature group #9571

Merged
merged 1 commit into from
Oct 30, 2023
Merged

馃摉 add proposal for karpenter integration feature group #9571

merged 1 commit into from
Oct 30, 2023

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Oct 18, 2023

What this PR does / why we need it:

Adds a proposal for the Karpenter feature group. This will help us to organize the Cluster API community around the activity of Karpenter usage with Cluster API by creating a central point of contact for contributors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9523

/area community-meeting

@k8s-ci-robot k8s-ci-robot added area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
CecileRobertMichon
CecileRobertMichon reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold for consensus until EOW as discussed in office hours

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 36c235c93f18482765448d692ca38115a759838b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@sbueringer
Copy link
Member

/lgtm

Thx for driving this @elmiko !

killianmuldoon
killianmuldoon reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@richardcase
Copy link
Member

/lgtm

@elmiko - do you have a meeting invite that you've added people to?

@elmiko
Copy link
Contributor Author

elmiko commented Oct 26, 2023 •
edited

@richardcase not yet, is there an official calendar where i could set that up?

edit:

is it worth proposing a change here? https://github.com/kubernetes/community/tree/master/sig-cluster-lifecycle

@jackfrancis
Copy link
Contributor

lgtm thx @elmiko

@elmiko
Copy link
Contributor Author

elmiko commented Oct 30, 2023

i will make a calendar item to add folks, i'm a little concerned about making it on my red hat calendar account but i will ask around to sig contribex first.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@sbueringer
Copy link
Member

I think for the community calendar you have to do it with a PR somewhere. @vincepri should know more afaik

@k8s-ci-robot k8s-ci-robot merged commit 5430298 into kubernetes-sigs:main Oct 30, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 30, 2023
@elmiko elmiko deleted the add-karpenter-integration-feature-group branch November 7, 2023 15:03
@jonathan-innis
Copy link
Member

jonathan-innis commented Nov 14, 2023 •
edited

@elmiko Is there any progress on starting a WG for Karpenter integration? I'd like to join but I don't yet see a calendar invite or set meeting time for this one.

Edit: Nvm, I found the time in the doc changes proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Create a feature group for Karpenter integration
8 participants
@elmiko @k8s-ci-robot @sbueringer @richardcase @jackfrancis @jonathan-innis @CecileRobertMichon @killianmuldoon