馃尡 update release-notes make target + corresponding doc #9573
Conversation
k8s-ci-robot
added
area/release
cahillsf
changed the title
Makefile
Outdated
| else \ | ||
| go run ./hack/tools/release/notes.go --from=$(PREVIOUS_TAG) > $(RELEASE_NOTES_DIR)/$(RELEASE_TAG).md; \ | ||
| fi | ||
| release-notes: |
There was a problem hiding this comment.
We should probably update this target to be release-notes tool, as it's confusing to have this target just build the tool rather than producing the notes themselves.
There was a problem hiding this comment.
@killianmuldoon the target is already named as you are suggesting, perhaps you meant something else?
There was a problem hiding this comment.
I think he meant something like
build-release-notes-tool or release-notes-tool.
There was a problem hiding this comment.
pushed up some changes that i think resolve this -- lmk if i misunderstood the recommendation
|
/retitle 馃尡 update release-notes make target + corresponding doc |
k8s-ci-robot
changed the title
cahillsf
force-pushed
the
cahillsf/update-release-notes-gen-process
branch
from
01c06cd
to
309c7a7
Compare
cahillsf
force-pushed
the
cahillsf/update-release-notes-gen-process
branch
from
2bb50f1
to
de1b74c
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 44c8e3ef27c9e7998cc2c043ccfa7305343f1e2a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Updates the make target (which is not in use anymore) and the corresponding documentation for generating the release PR. The notes tool is frequently iterated on and to avoid excess overhead of backporting all the changes to
release-*branches the updated process is to always build the binary from main, then checkout the relevant branches.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9556
/area release