Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump kubebuilder tools to v0.4.2 #9665

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2023
@sbueringer
Copy link
Member Author

/assign @killianmuldoon @fabriziopandini @chrischdi

cc @kubernetes-sigs/cluster-api-release-team

@furkatgofurov7
Copy link
Member

I think we need to merge kubernetes-sigs/kubebuilder-release-tools#58 before taking this in?

cc @mjlshen

@furkatgofurov7
Copy link
Member

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing and removed do-not-merge/needs-area PR is missing an area label labels Nov 3, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release v0.4.2 is still using the outdated image in its action. The current plan was to bump the versions in the kubebuilder-tools repo and then use the sha of the commit for this action so we get the correct image version.

I'm not sure when we'll get a future release of kubebuilder-tools but we should be sure to track it so we can go back to a tagged version of this action.

@furkatgofurov7
Copy link
Member

I'm not sure when we'll get a future release of kubebuilder-tools but we should be sure to track it so we can go back to a tagged version of this action.

Yeah, probably not too soon based on the slack conversations @vincepri was also suggesting to you use sha of the commit in the meantime

@killianmuldoon
Copy link
Contributor

Fine IMO to merge this as is, but it won't unblock us. Let's merge this and wait for the updates in kubebuilder and do a follow up bump.

/cc @mjlshen

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2157673f0b0f5b9fcbf73c9283045e14d889bdec

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit dec1667 into kubernetes-sigs:main Nov 3, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Nov 3, 2023
@sbueringer
Copy link
Member Author

Do we know if the action works after the last fix? If we don't know, let's bump to the sha of the right commit to test it.

We shouldn't trial-and-error going forward with kubebuilder-release-tools releases

@sbueringer sbueringer deleted the pr-bump-kb-tools branch November 4, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants