Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/conformance: add variables to overwrite parralelization of kubetest runs #9667

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This PR adds environment variables to the test framework to allow overwriting the variables NumberOfNodes and GinkgoNodes, which are passed to kubetest runs.

Currently this variables resolve to the hardcoded value of 5, coming from the workerMachineCount.

We are trying to run the upstream serial, alpha-features and slow tests.

  • serial and alpha-features requires a value of 1
  • slow tests require a value of 25

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

related to: kubernetes-sigs/cluster-api-provider-vsphere#2452

/area e2e-testing

…and KUBETEST_GINKGO_NODES to allow overwriting hardcoded kubetest configuration
@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b59bfe2f84fb108b4c214336e30f3965426abf24

@sbueringer sbueringer changed the title test/conformance: add variables to overwrite parralelization of kubetest runs 🌱 test/conformance: add variables to overwrite parralelization of kubetest runs Nov 3, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit f44c0eb into kubernetes-sigs:main Nov 3, 2023
26 of 27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants