Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 🌱 Bump github.com/docker/docker from 24.0.5 to 24.0.7 #9675

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[release-1.5] 🌱 Bump github.com/docker/docker from 24.0.5 to 24.0.7 #9675

merged 1 commit into from
Nov 6, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Nov 6, 2023 •
edited

Manual cherry-pick of #9652

Fixes CVEs GHSA-jq35-85cj-fj4p

@killianmuldoon
Bump github.com/docker/docker from 24.0.5 to 24.0.7
da1b8b5 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Nov 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 6, 2023
killianmuldoon
killianmuldoon commented Nov 6, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area dependency

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels Nov 6, 2023
@killianmuldoon
Copy link
Contributor Author

killianmuldoon commented Nov 6, 2023 •
edited

I'm not sure I understand why, but this issue was picked up by the Trivy scan in release-1.5 but was not reported as an issue: https://github.com/kubernetes-sigs/cluster-api/actions/runs/6770431773/job/18398823201

It appears in the logs, but just doesn't result in an error.

Edit: Looks like there's a bug in the script on main and in release-1.5. Should be fixed by #9676

@killianmuldoon killianmuldoon mentioned this pull request Nov 6, 2023
Merged
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6cf588e0871c15e0404e2b4236d75354733f89f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit ef08e84 into kubernetes-sigs:release-1.5 Nov 6, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@killianmuldoon @sbueringer @k8s-ci-robot