馃尡 Avoid cd'ing into test folders when building Docker images #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
force-pushed
the
pr-fixup-build
branch
from
59de486
to
be394a7
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d86817dc5c730869ae8827cd75116ef96650aaac
|
nawazkh
reviewed
Nov 21, 2023
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fixup-build
branch
from
be394a7
to
e1ae606
Compare
k8s-ci-robot
removed
the
lgtm
|
Pushed a fix |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 51eb25946b72d669b546cf5a1171151a1408bf01
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm++ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Looks like we currently get (at least) the test/extension binary in some of our CAPD images for some architectures. Potentially more provider / architectures are affected.
We are currently guessing that running
make release-stagingwith-j 8 -Otriggers this behavior. Basically we guess that the cd commands are getting mixed up with the docker build commands and then we produce CAPD images based on the wrong Dockerfile which then builds the test/extension.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #