From b7e8cebb7473f25a982a0ca281d0e577a374d187 Mon Sep 17 00:00:00 2001 From: Chris Bandy Date: Sat, 30 Mar 2024 11:24:54 -0500 Subject: [PATCH] Quiet context.Canceled errors during shutdown Runnable implementations that return ctx.Err() cause a spurious "error received after stop" log message. --- pkg/manager/internal.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/manager/internal.go b/pkg/manager/internal.go index a16f354a1b..396dbcd569 100644 --- a/pkg/manager/internal.go +++ b/pkg/manager/internal.go @@ -485,8 +485,8 @@ func (cm *controllerManager) engageStopProcedure(stopComplete <-chan struct{}) e cm.internalCancel() }) select { - case err, ok := <-cm.errChan: - if ok { + case err := <-cm.errChan: + if !errors.Is(err, context.Canceled) { cm.logger.Error(err, "error received after stop sequence was engaged") } case <-stopComplete: