Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.16.1
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.16.2
Choose a head ref
  • 15 commits
  • 10 files changed
  • 7 contributors

Commits on Aug 31, 2023

  1. add corev1, coordinationv1 scheme for leader election when LeaderElec…

    …tion option is true
    
    Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
    troy0820 committed Aug 31, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    Copy the full SHA
    98224fa View commit details

Commits on Sep 1, 2023

  1. Merge pull request #2466 from troy0820/troy0820/16-add-types-to-leade…

    …r-election
    
    [release-0.16] 🐛 Add corev1, coordinationv1 scheme for leader election when LeaderElection manager option is true
    k8s-ci-robot authored Sep 1, 2023
    Copy the full SHA
    41ce001 View commit details

Commits on Sep 4, 2023

  1. use http client from leaderElectionConfig

    Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
    troy0820 authored and k8s-infra-cherrypick-robot committed Sep 4, 2023
    Copy the full SHA
    6bd5cca View commit details
  2. Merge pull request #2468 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2464-to-release-0.16
    
    [release-0.16] 🐛 Use http client from leaderElectionConfig
    k8s-ci-robot authored Sep 4, 2023
    Copy the full SHA
    240440a View commit details

Commits on Sep 9, 2023

  1. [release-0.16] 🐛 Default namespace only for namespaced object (#2482)

    * Default namespace only for namespaced object
    
    * Add test
    
    ---------
    
    Co-authored-by: Sonu Kumar Singh <sksgkpvks@gmail.com>
    k8s-infra-cherrypick-robot and acumino authored Sep 9, 2023
    Copy the full SHA
    94cefd3 View commit details
  2. update subresource client to not incude metadata

    Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
    troy0820 authored and k8s-infra-cherrypick-robot committed Sep 9, 2023
    Copy the full SHA
    f4582ea View commit details
  3. Test showing labels and annotations stored during fake client.Status(…

    …).Update()
    berlin-ab authored and k8s-infra-cherrypick-robot committed Sep 9, 2023
    Copy the full SHA
    74eb8ea View commit details
  4. add test case to show it will not override other status fields when u…

    …pdating
    
    Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
    troy0820 authored and k8s-infra-cherrypick-robot committed Sep 9, 2023
    Copy the full SHA
    b3c83a2 View commit details
  5. delete copyNonStatusFrom function, change test case description

    Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
    troy0820 authored and k8s-infra-cherrypick-robot committed Sep 9, 2023
    Copy the full SHA
    339df9a View commit details
  6. Merge pull request #2483 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2479-to-release-0.16
    
    [release-0.16] 🐛 Do not update anything but status when using subresource client
    k8s-ci-robot authored Sep 9, 2023
    Copy the full SHA
    580f203 View commit details
  7. bug: Fix status subresource getting updated on Update when it is empty

    Before this, Update and Patch requests will override to-level status
    fields for objects that have a status resource if the status was
    initially empty.
    
    This happens because the code to set the status to what we already have
    in the unupdated object converts the object into a `map[string]any`
    using json serialization/deserialization, copies the original `status`
    field, then converts back. The json deserializer unfortunatelly does not
    properly clear the target, allowing data to remain that is absent in the
    json serialization.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed Sep 9, 2023
    Copy the full SHA
    319038d View commit details
  8. Merge pull request #2485 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2484-to-release-0.16
    
    [release-0.16] 🐛 Fix status subresource getting updated on Update when it is empty
    k8s-ci-robot authored Sep 9, 2023
    Copy the full SHA
    1cf5b88 View commit details

Commits on Sep 10, 2023

  1. [release-0.16] 🐛 Fix returning object after status update (#2490)

    * Draft: Test that an object is updatable after updating its status.
    
    * Draft: ensure we udpate the new obj's accessor's ResourceVersion after doing the deep copy
    
    * Rework code to pass object back on status update
    
    ---------
    
    Co-authored-by: Adam Berlin <aberlin@vmware.com>
    Co-authored-by: Alvaro Aleman <alvaroaleman@users.noreply.github.com>
    3 people authored Sep 10, 2023
    Copy the full SHA
    b40bcb8 View commit details

Commits on Sep 11, 2023

  1. bug: Return NoResourceMatchError when appropriate for backwards compa…

    …tibility.
    porridge authored and k8s-infra-cherrypick-robot committed Sep 11, 2023
    Copy the full SHA
    ca2d236 View commit details
  2. Merge pull request #2492 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2472-to-release-0.16
    
    [release-0.16] 🐛 Return NoResourceMatchError when appropriate for backwards compatibility.
    k8s-ci-robot authored Sep 11, 2023
    Copy the full SHA
    7db81c7 View commit details
Loading