Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable stack traces for zap logs --zap-stacktrace-level #1035

Closed
bharathi-tenneti opened this issue Jul 8, 2020 · 6 comments · Fixed by #1348
Closed

Add option to disable stack traces for zap logs --zap-stacktrace-level #1035

bharathi-tenneti opened this issue Jul 8, 2020 · 6 comments · Fixed by #1348
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Milestone

Comments

@bharathi-tenneti
Copy link
Contributor

Description:
Allow users to disable stacktraces , using --zap-stacktrace-level, when running the operator.

@vincepri
Copy link
Member

You should be able to register the flag in your controller, like we do for klog. I'm not sure if there is anything for controller-runtime to do in this case.

@vincepri
Copy link
Member

/priority awaiting-more-evidence
/milestone Next

@k8s-ci-robot k8s-ci-robot added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the Next milestone Jul 22, 2020
@camilamacedo86
Copy link
Member

@vincepri it is related to : #915 after merge this one we would be nice be allowed to disable/enable it.

@camilamacedo86
Copy link
Member

Hi @vincepri,

For we You should be able to register the flag in your controller, like we do for klog. I'm not sure if there is anything for controller-runtime to do in this case. the user requires to do the change in the code, Am I right? If yes, I understand that the flag allows disable/enable the logs on the cluster where the project is running without code changes.

if I am wrong here, I think we can just add an example here how to do your suggestion and then close this one.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2021
@croomes
Copy link
Contributor

croomes commented Jan 21, 2021

I had the same issue but I couldn't find a good way to disable stack traces completely. I checked klog but couldn't find anything relevant. Allowing the user to set panic as the --zap-stacktrace-level seems like a simple solution.

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants