🌱 Update json-patch to v4.9.0

[vincepri]

Signed-off-by: Vince Prignano vincepri@vmware.com

/assign @alvaroaleman
/milestone v0.7.x

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

This will also be backported to v0.6.x and v0.5.x

[vincepri]

/retest

[alvaroaleman]

@vincepri what does that jsonpatch update bring? Did kube update to 0.4.9 as well?

[vincepri]

Yes, this latest version has Jordan's fixes, like evanphx/json-patch#108

[alvaroaleman]

@vincepri from what I can see, upstream updated to 4.8.0, not 4.9.0: kubernetes/kubernetes#93812

[vincepri]

The v0.4.9 release is more recent and carries other bug fixes as well. The v0.4.8 release cannot be used in controller-runtime because it's not addressable by tag, only by commit and because we import another jsonpatch library for webhooks, go.mod won't let us use the commit, but it'll resolve to v0.4.2 IIRC.

@liggitt do you have a timeline for updating to v0.4.9 upstream?

[liggitt]

already done in master / 1.19: kubernetes/kubernetes#94147

picks open, I expect they'll be in the next patch releases:

• 1.16 - [1.16] Update to json-patch 4.9.0 kubernetes/kubernetes#94150
• 1.17 - [1.17] Update to json-patch 4.9.0 kubernetes/kubernetes#94149
• 1.18 - [1.18] Update to json-patch 4.9.0 kubernetes/kubernetes#94148

[vincepri]

Perfect, thank you!

[alvaroaleman]

/lgtm

[vincepri]

/test pull-controller-runtime-test-master