🐛 Controller: Return error when started more than once #1139
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Starting the controller more than once is always wrong. Today, it will result in: * Its active workqueue being re-created, resulting in a data race, breaking the guarantee of "there is at most one worker on a given queue key" and messed-up metrics * Starting double as many workers as configured This PR changes that to instead return an error on all subsequent Start attempts.
k8s-ci-robot
added
the
size/S
alvaroaleman
force-pushed
the
error-on-multiple-start
branch
from
10c8a01
to
db22614
Compare
k8s-ci-robot
added
the
lgtm
|
@vincepri: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/milestone v0.7.x |
Starting the controller more than once is always wrong. Today, it will
result in:
breaking the guarantee of "there is at most one worker on a given
queue key" and messed-up metrics
This PR changes that to instead return an error on all subsequent Start
attempts.
/assign @vincepri