Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update dependencies to v0.19.2 #1170

Merged
merged 1 commit into from Sep 20, 2020

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano vincepri@vmware.com

/assign @alvaroaleman @DirectXMan12
/milestone v0.7.x

Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Sep 18, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2020
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit aee0ef1 into kubernetes-sigs:master Sep 20, 2020
@estroz estroz mentioned this pull request Nov 3, 2020
@george-angel
Copy link

Hello, is this issue relevant again?

Trying to update deps:

$ go get -u
# sigs.k8s.io/controller-runtime/pkg/log
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/deleg.go:79:12: undefined: logr.WithCallDepth
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/deleg.go:163:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/deleg.go:179:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/deleg.go:195:2: cannot use res (type *DelegatingLogger) as type logr.Logger in return argument
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/log.go:67:26: cannot use NullLogger{} (type NullLogger) as type logr.Logger in argument to Log.Fulfill
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/log.go:82:41: cannot use NullLogger{} (type NullLogger) as type logr.Logger in argument to NewDelegatingLogger
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/log.go:86:6: cannot use Log (type *DelegatingLogger) as type logr.Logger in assignment
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/log.go:88:13: assignment mismatch: 1 variable but logr.FromContext returns 2 values
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/null.go:30:5: cannot use NullLogger{} (type NullLogger) as type logr.Logger in assignment
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/null.go:49:2: cannot use log (type NullLogger) as type logr.Logger in return argument
../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.2/pkg/log/null.go:49:2: too many errors

@vincepri
Copy link
Member Author

@george-angel The klog/klogr dependencies must match what's defined in controller-runtime

@george-angel
Copy link

Thanks @vincepri , I think the fault is my own, I tried updating to go 1.17 in my go.mod and I can see that controller-runtime is using 1.16. Let me debug further and raise an issue with more detail if I feel one actually exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants