Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread safety issue in controller-runtime v0.6 #1172

Closed
adrianludwin opened this issue Sep 22, 2020 · 6 comments
Closed

Fix thread safety issue in controller-runtime v0.6 #1172

adrianludwin opened this issue Sep 22, 2020 · 6 comments
Assignees
@DirectXMan12

Comments

@adrianludwin
Copy link

This is a request to fix #1148 in the v0.6 branch by cherry-picking #1155. I tried this out myself in github.com/adrianludwin/controller-runtime v0.6.3-ts-fix and it works perfectly with HNC - in fact, we're patching HNC with that right now (kubernetes-retired/multi-tenancy#1127) since we don't want to wait for the official fix, but I'd like to get back onto the official controller-runtime releases ASAP.

Thanks!

/assign @DirectXMan12
@adrianludwin
Copy link
Author

Hi, any chance we'll be able to get a fix for this on the v0.6 branch? Thanks!

@alex1989hu
Copy link

/cc @vincepri

@vincepri
Copy link
Member

Feel free to open a PR to cherry pick PR to the release-0.6 branch

@adrianludwin adrianludwin mentioned this issue Oct 22, 2020
Merged
@adrianludwin
Copy link
Author

Done, PTAL

@yiqigao217
Copy link

Can this issue be closed with https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.6.4? @adrianludwin

@adrianludwin
Copy link
Author

Yup! Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DirectXMan12 DirectXMan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DirectXMan12 @vincepri @alex1989hu @adrianludwin @yiqigao217