🐛 add error check when no apiType is provided for reconciliation #1182
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @prafull01. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
| @@ -167,6 +167,10 @@ func (blder *Builder) Build(r reconcile.Reconciler) (controller.Controller, erro | |||
| if blder.forInput.err != nil { | |||
| return nil, blder.forInput.err | |||
| } | |||
| // Checking the reconcile type exist or not | |||
| if blder.forInput.object == nil { | |||
| return nil, fmt.Errorf("must provide an object for reconciliation") | |||
There was a problem hiding this comment.
please use errors.New for error messages without a format string
There was a problem hiding this comment.
@alvaroaleman In the same func, fmt.Errorf is used for other errors which do not have a format string. IMHO this needs to be fixed horizontally for all such error messages.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-controller-runtime-test-master |
|
@prafull01: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
When no reconciliation type is provided in the For(...) function to the Builder, it used to panic. Added the error handling if no apiType is provided in the For(...) function.
Fixes #1181