🌱 Update Go mod version to 1.15 #1187
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
|
/retest |
| @@ -1,6 +1,6 @@ | |||
| module sigs.k8s.io/controller-runtime | |||
|
|
|||
| go 1.13 | |||
| go 1.15 | |||
There was a problem hiding this comment.
The presubmits still run with go 1.13, so we should probably change that first: https://github.com/kubernetes/test-infra/blob/f6e9dbfd16c179a89c84f98481326884ca69bcc4/config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-presubmits-master.yaml#L12
and why does specifying a newer go version than used in the tests not make the tests fail?
There was a problem hiding this comment.
From https://golang.org/doc/go1.12#modules:
The go directive in a go.mod file now indicates the version of the language used by the files within that module. It will be set to the current release (go 1.12) if no existing version is present. If the go directive for a module specifies a version newer than the toolchain in use, the go command will attempt to build the packages regardless, and will note the mismatch only if that build fails.
There was a problem hiding this comment.
I'll open a PR in test-infra to update the version
There was a problem hiding this comment.
k8s-ci-robot
added
the
lgtm
|
/test pull-controller-runtime-test-master |
|
/retest Not sure why now the tests are failing, hope it's not related, I've been testing locally with 1.15 for a long while |
|
/test pull-controller-runtime-test-master |
Signed-off-by: Vince Prignano vincepri@vmware.com
Fixes #825
/milestone v0.7.x
/assign @alvaroaleman