馃尡 Expose handler.MapFunc to allow implementers to test mappers #1194
Conversation
This is a follow-up from a previous change to the handler package that deprecated the old handler.ToRequestFunc in favor of EnqueueRequestsFromMapFunc. While we still want to prefer using EnqueueRequestsFromMapFunc, this change also exposes the type of MapFunc signature expected. Users can use this type to test their own mappers in unit tests. Signed-off-by: Vince Prignano <vincepri@vmware.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @alvaroaleman |
k8s-ci-robot
added
approved
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vincepri @alvaroaleman Hi, I noticed that the mapper struct has been removed. I want to known how could i inject client into my mapper function use |
This is a follow-up from a previous change to the handler package that
deprecated the old handler.ToRequestFunc in favor of
EnqueueRequestsFromMapFunc.
While we still want to prefer using EnqueueRequestsFromMapFunc, this
change also exposes the type of MapFunc signature expected. Users can
use this type to test their own mappers in unit tests.
Signed-off-by: Vince Prignano vincepri@vmware.com