Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use kubebuilder-release-tools #1197

Merged
merged 1 commit into from Oct 1, 2020

Conversation

DirectXMan12
Copy link
Contributor

This updates the versioning/releasing docs to mention the new Go tooling
in k-sigs/kubebuilder-release-tools (replacing the hack/release
scripts), and adds the verifier action to a workflow to run on all PRs
in this repo.

This updates the versioning/releasing docs to mention the new Go tooling
in k-sigs/kubebuilder-release-tools (replacing the hack/release
scripts), and adds the verifier action to a workflow to run on all PRs
in this repo.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@DirectXMan12 DirectXMan12 requested review from vincepri and removed request for joelanford and pwittrock October 1, 2020 21:15
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2020
@DirectXMan12
Copy link
Contributor Author

NB: for security reasons, this won't kick in till it gets merged (that's what the pull_request_target does).

@DirectXMan12
Copy link
Contributor Author

It's been tested over in the main kubebuilder-release-tooling repo though.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit a6e9977 into kubernetes-sigs:master Oct 1, 2020
@DirectXMan12 DirectXMan12 deleted the infra/checking branch October 1, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants