馃悰 Tracker upgrade should use gvk from scheme #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
vincepri
reviewed
Oct 9, 2020
|
lgtm pending Vince's suggestion and fixing the PR title to appease the checks. |
fabriziopandini
force-pushed
the
tracker-upgrade-should-use-gvk-from-scheme
branch
from
07a7a8c
to
87480a7
Compare
|
/milestone v0.7.x |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@fabriziopandini Please fix the PR title cc @DirectXMan12 Not sure why the check isn't running anymore 馃 |
fabriziopandini
changed the title
|
/test pull-controller-runtime-test-master |
fabriziopandini
deleted the
tracker-upgrade-should-use-gvk-from-scheme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure
tracker.Upgradeuses the gvk from scheme forAllowUnconditionalUpdateandAllowCreateOnUpdatein caseTypeMetais not defined on the objFixes: #1212