Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix use of UnstructuredList with unregistered typed #1238

Merged

Conversation

ironcladlou
Copy link
Contributor

Before this change, passing an unstructured.UnstructuredList to
client.List() would erroneously delegate to the typed client, causing an error
if the target type isn't registered with the client's scheme, violating the
purpose of using unstructured.

This patch fixes the client so that the unstructured.UnstructuredList is
delegated to the internal unstructured client.

Before this change, passing an `unstructured.UnstructuredList` to
`client.List()` would erroneously delegate to the typed client, causing an error
if the target type isn't registered with the client's scheme, violating the
purpose of using `unstructured`.

This patch fixes the client so that the `unstructured.UnstructuredList` is
delegated to the internal unstructured client.
@k8s-ci-robot
Copy link
Contributor

Hi @ironcladlou. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2020
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@ironcladlou
Copy link
Contributor Author

Here's an example of what the failure looks like:

list := &unstructured.UnstructuredList{}
list.SetGroupVersionKind(schema.GroupVersionKind{
  Group:   "group.example.com",
  Version: "v1",
  Kind:    "FooList",
})
client.List(context.TODO(), list)
v1.ListOptions is not suitable for converting to "group.example.com/v1" in scheme "example.go:xx"

@alvaroaleman
Copy link
Member

/retest

@alvaroaleman
Copy link
Member

The heck.
/retest

@k8s-ci-robot k8s-ci-robot merged commit 9975e29 into kubernetes-sigs:master Nov 2, 2020
astefanutti added a commit to apache/camel-k that referenced this pull request Mar 1, 2021
Version 0.6.4 causes "v1.ListOptions is not suitable for converting to"
errors in the GC trait.
See: kubernetes-sigs/controller-runtime#1238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants