New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Fix use of UnstructuredList
with unregistered typed
#1238
馃悰 Fix use of UnstructuredList
with unregistered typed
#1238
Conversation
Before this change, passing an `unstructured.UnstructuredList` to `client.List()` would erroneously delegate to the typed client, causing an error if the target type isn't registered with the client's scheme, violating the purpose of using `unstructured`. This patch fixes the client so that the `unstructured.UnstructuredList` is delegated to the internal unstructured client.
Hi @ironcladlou. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here's an example of what the failure looks like: list := &unstructured.UnstructuredList{}
list.SetGroupVersionKind(schema.GroupVersionKind{
Group: "group.example.com",
Version: "v1",
Kind: "FooList",
})
client.List(context.TODO(), list)
|
/retest |
The heck. |
Version 0.6.4 causes "v1.ListOptions is not suitable for converting to" errors in the GC trait. See: kubernetes-sigs/controller-runtime#1238
Before this change, passing an
unstructured.UnstructuredList
toclient.List()
would erroneously delegate to the typed client, causing an errorif the target type isn't registered with the client's scheme, violating the
purpose of using
unstructured
.This patch fixes the client so that the
unstructured.UnstructuredList
isdelegated to the internal unstructured client.