Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove duplicate lines in controller.go #1240

Merged

Conversation

horis233
Copy link
Contributor

@horis233 horis233 commented Nov 3, 2020

When I read the controller.go file, I found this step is duplicated with https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/controller/controller.go#L99-L101. Thus I create a PR to remove it.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @horis233. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2020
@horis233 horis233 changed the title ✨ remove the duplicate steps :sparkles remove the duplicate steps Nov 3, 2020
@horis233 horis233 changed the title :sparkles remove the duplicate steps ✨ remove the duplicate steps Nov 3, 2020
@horis233
Copy link
Contributor Author

horis233 commented Nov 3, 2020

/assign @gerred

@horis233 horis233 changed the title ✨ remove the duplicate steps ✨ remove the duplicate steps Nov 3, 2020
@vincepri
Copy link
Member

vincepri commented Nov 3, 2020

/ok-to-test
/approve
/lgtm
/retitle 🌱 Remove duplicate lines in controller.go

@k8s-ci-robot k8s-ci-robot changed the title ✨ remove the duplicate steps 🌱 Remove duplicate lines in controller.go Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: horis233, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2020
@vincepri
Copy link
Member

vincepri commented Nov 3, 2020

Thank you!

@k8s-ci-robot k8s-ci-robot merged commit a156834 into kubernetes-sigs:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants