🌱 Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics

[irajdeep]

The current metric uses Prometheus default bucket for reconcile time histogram. This bucket is
not sufficient to reason about the percentile of requests which take less than x seconds when x falls outside
the bucket of 10 secs(current last bucket). It's also hard to infer when the reconcile loops are fairly fast, as mentioned in
this issue: #258.

This PR attempts to define explicit buckets for the metrics, values are chosen based on the API-server
request latency defined here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103.
The default Prometheus histogram buckets have also been added(wherever missing) to ensure backward compatibility.

[k8s-ci-robot]

Welcome @irajdeep!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @irajdeep. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coderanger]

This PR attempts to define explicit buckets for the metrics, values are chosen based on the API-server
request latency defined here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103.

https://github.com/kubernetes/kubernetes/blob/c652ffbe4a29143623a1aaec39f745575f7e43ad/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103 for the future.

[alvaroaleman]

/lgtm
/assign @vincepri

[alvaroaleman]

/retitle 🌱 Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics

[alvaroaleman]

/approve cancel
leaving that to vince

[vincepri]

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irajdeep, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment