✨ Add fake.NewClientBuilder to build new fake clients #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/milestone v0.7.x |
k8s-ci-robot
added
the
size/M
vincepri
force-pushed
the
fake-client-builder
branch
from
6ffd8ac
to
5401ae1
Compare
|
/retest |
This change allows us to iterate on the fake client without relying on a small set of arguments passed to NewFakeClient/NewFakeClientWithScheme. The new builder accepts a variety of options to initialize the fake client, including the scheme. Because the builder seems more of a long term solution, I've marked the older functions as deprecated in favor of NewClientBuilder. Note: I dropped the "Fake" prefix given that it stutters with the package name. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
fake-client-builder
branch
from
5401ae1
to
d915eb1
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to iterate on the fake client without relying on
a small set of arguments passed to
NewFakeClient/NewFakeClientWithScheme.
The new builder accepts a variety of options to initialize the fake
client, including the scheme.
Because the builder seems more of a long term solution, I've marked the
older functions as deprecated in favor of NewClientBuilder.
Note: I dropped the "Fake" prefix given that it stutters with the
package name.
/assign @alvaroaleman