🐛 client.List should check on UnstructuredList, not Unstructured #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After adding the metadata only watch and client support, the List object was type checking on `Unstructured` instead of `UnstructuredList`. Now! "Why were the tests passing??" one might ask, it seems that even though our tests had some using UnstructuredLists and querying against List, the objects we were asking (appsv1/Deployments) are core objects that are usually included in the default client-go scheme.Scheme. For the above reason, the internal `typedClient` was able to make the request to the API server and convert the list of object back to UnstructuredList. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
unstructed-list-bug-06
branch
from
5996c92
to
df4e60f
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding the metadata only watch and client support, the List object
was type checking on
Unstructuredinstead ofUnstructuredList.Now! "Why were the tests passing??" one might ask, it seems that even
though our tests had some using UnstructuredLists and querying against
List, the objects we were asking (appsv1/Deployments) are core objects
that are usually included in the default client-go scheme.Scheme.
For the above reason, the internal
typedClientwas able to make therequest to the API server and convert the list of object back to
UnstructuredList.
/milestone v0.6.x
/assign @alvaroaleman @DirectXMan12