🐛 Fakeclient: Do not require ListKind #1467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake client will currently error out of given a Kind in an
UnstructuredList that doesn't end with list. This is different from what
we do in the actual client, where we tolerate that:
controller-runtime/pkg/client/unstructured_client.go
Line 204 in 10ae090
This change brings the fake client in line with the real client.
Related: The comments on #702 although the Bug itself is about something else.
/assign @vincepri