New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ pkg/log/zap: clarify zap level vs. logr verbosity #1485
Conversation
pkg/log/zap/zap.go
Outdated
// Level sets the the minimum enabled logging level e.g Debug, Info | ||
// See Options.Level | ||
// Level sets Options.Level, which configures the the minimum enabled logging level e.g Debug, Info. | ||
// If using zapcore.Level(N), where N > 0, set zapcore.Level(-1*N) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line feels confusing, I think you mean the second bit to be Level(-1*N)
for how to call this function? Or the first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lmk if my update makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Clearer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with coderanger... this line is hard to parse... otherwise lgtm
…xplanation and test cases Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
/test pull-controller-runtime-test-master |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, estroz, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR clarifies zap level vs. logr verbosity with a link to the zapr explanation of this difference, and test cases.
/kind documentation
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com