⚠ Avoid shallow copies of webhooks and CRDs in testenv #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
pointer-crds-webhooks
branch
from
4b3c568
to
a14a68c
Compare
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @alvaroaleman |
alvaroaleman
approved these changes
Sep 21, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
acumino
added a commit
to acumino/gardener
that referenced
this pull request
Feb 8, 2022
acumino
added a commit
to acumino/gardener
that referenced
this pull request
Feb 11, 2022
acumino
added a commit
to acumino/gardener
that referenced
this pull request
Feb 11, 2022
timebertt
added a commit
to gardener/gardener
that referenced
this pull request
Feb 14, 2022
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
acumino
added a commit
to acumino/test-infra
that referenced
this pull request
Jul 19, 2022
acumino
added a commit
to acumino/test-infra
that referenced
this pull request
Jul 19, 2022
acumino
added a commit
to acumino/test-infra
that referenced
this pull request
Jul 20, 2022
hendrikKahl
pushed a commit
to gardener/test-infra
that referenced
this pull request
Jul 20, 2022
* run go mod tidy before go mod vendor to make make revendor * Vendor gardener v1.51.0 * Update k8s dependecies * Update controller-runtime * Import hack * Update Argo Workflow * Update make file to use tools * Update component cli * Update component spec * Update component cli * Adapt changes for NullLogger * Adapt changes for logger changed to construct * Avoid shallow copies of CRDs ref kubernetes-sigs/controller-runtime#1667 * gitignore tools bin dir * make generate and make revendor * delete ignored files * Update images * Add CRDs and adapt cluster role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
/assign @alvaroaleman