Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Allow Specification of the Log Timestamp Format #1688

Merged
merged 1 commit into from Oct 11, 2021
Merged

🌱 Allow Specification of the Log Timestamp Format #1688

merged 1 commit into from Oct 11, 2021

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Oct 8, 2021

Currently the user doesn't have an option to specify the encoding of the log timestamps via a command line flag. So by default all log timestamps are in epoch format, which makes them hard to read/interpret imho.

This PR addresses it and adds the zap-time-encoding flag, which allows to specify the required format for log timestamp encoding and accepts the following values:

  • epoch: floating-point number of seconds since the Unix epoch
  • nanos: integer of nanoseconds since the Unix epoch
  • millis: floating-point number of milliseconds since the Unix epoch
  • iso8601: ISO8601-formatted string with millisecond precision
  • rfc3339: RFC3339-formatted string or
  • rfc3339nano: RFC3339-formatted string with nanosecond precision.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @creydr!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @creydr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2021
@alvaroaleman
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2021
alvaroaleman
alvaroaleman reviewed Oct 8, 2021
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2021
@creydr
Copy link
Contributor Author

creydr commented Oct 11, 2021

/retest

alvaroaleman
alvaroaleman reviewed Oct 11, 2021
View reviewed changes
pkg/log/zap/zap.go Outdated Show resolved Hide resolved
@creydr
Add zap-time-encoding flag
5bb6cb7 
    Adds the --zap-time-encoding flag to specify the output format of the log
    timestamp. Allows:
    epoch (floating-point number of seconds since the Unix epoch),
    nanos (integer of nanoseconds since the Unix epoch),
    millis (floating-point number of milliseconds since the Unix epoch),
    iso8601 (ISO8601-formatted string with millisecond precision),
    rfc3339 (RFC3339-formatted string) and
    rfc3339nano (RFC3339-formatted string with nanosecond precision).

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr
Copy link
Contributor Author

creydr commented Oct 11, 2021

/retest

alvaroaleman
alvaroaleman approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit ffa8c50 into kubernetes-sigs:master Oct 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Oct 11, 2021
@creydr
Copy link
Contributor Author

creydr commented Oct 12, 2021

Thanks!

@alvaroaleman Thanks for your patience.

@creydr creydr mentioned this pull request Jan 18, 2022
Merged
@creydr creydr mentioned this pull request Mar 11, 2022
Merged
@lsolovey lsolovey mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@creydr @k8s-ci-robot @alvaroaleman