Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ bump k8s to 1.23-alpha.3 #1709

Merged

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Oct 29, 2021

This PR bumps the k8s dependencies to 1.23-alpha.3

Note
Since k8s 1.23 uses go-logr/logr v1.1.0, this PR also
bumps logr to the latest version.

Co-authored-by: "Morlay" morlay.null@gmail.com

While working on this I realized that there is already a PR open to bump go-logr/logr to 1.1.0 (#1593). @morlay, I have added those changes here, if we are going to cut a release without k8s bump, I can rebase this after #1593 is merged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2021
@varshaprasad96
Copy link
Member Author

K8s 1.23 is scheduled to release on Dec 7. We can either merge this in master (if there is not going to be any other release meanwhile), or wait till 1.23.

This PR bumps the k8s dependencies to 1.23-alpha.3

**Note**
Since k8s 1.23 uses go-logr/logr v1.1.0, this PR also
bumps logr to the latest version.

Co-authored-by: "Morlay"<morlay.null@gmail.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2021

@varshaprasad96: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff-master 958ff15 link false /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0a3dd2a into kubernetes-sigs:master Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Nov 2, 2021
@jmrodri
Copy link
Contributor

jmrodri commented Nov 4, 2021

/cc @joelanford

Nabil372 pushed a commit to gocardless/theatre that referenced this pull request Nov 15, 2022
Upgrades controller-runtime from v0.10.3 to v0.11.2.
Breaking changes described here:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.11.0

There was a breaking change to the `go-logr` module.

Refactored our logging package in order to implement the new
`go-logr` interface.
Referred to the following code/PRs on how to do that:
- kubernetes-sigs/controller-runtime#1709
https://github.com/varshaprasad96/controller-runtime/blob/958ff158cbb375164a9ddac0cdee8ba05ae232b4/pkg/log/log_test.go
go-logr/logr#42

Bumped controller-gen from v0.7.0 to v0.8.0.
https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.8.0
Nabil372 pushed a commit to gocardless/theatre that referenced this pull request Nov 30, 2022
Upgrades controller-runtime from v0.10.3 to v0.11.2.
Breaking changes described here:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.11.0

There was a breaking change to the `go-logr` module.

Refactored our logging package in order to implement the new
`go-logr` interface.
Referred to the following code/PRs on how to do that:
- kubernetes-sigs/controller-runtime#1709
https://github.com/varshaprasad96/controller-runtime/blob/958ff158cbb375164a9ddac0cdee8ba05ae232b4/pkg/log/log_test.go
go-logr/logr#42

Bumped controller-gen from v0.7.0 to v0.8.0.
https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants