Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump to Go 1.17, k8s.io v1.23-alpha4, gomega v1.17.0, bump setup-envtest deps #1714

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 10, 2021

Signed-off-by: Stefan Büringer buringerst@vmware.com

Bumps dependencies. Especially setup-envtest is important as otherwise it isn't compatible with dependencies of the main go.mod (log dependencies).

Note: this bumps to alpha4 and thus requires Go 1.17
Thus it depends on kubernetes/test-infra#24311

locally verified with go v1.17.2 + ./hack/ci-check-everything.sh

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2021
@sbueringer sbueringer changed the title ✨ Bump to gomega v1.17.0, v1.23-alpha4, bump setup-envtest deps ✨ Bump to Go 1.17, k8s.io v1.23-alpha4, gomega v1.17.0, bump setup-envtest deps Nov 10, 2021
@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 619e6b9 into kubernetes-sigs:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Nov 10, 2021
@sbueringer sbueringer deleted the pr-upgrade-deps-alpha4 branch November 10, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants