🐛 Correctly pass cache options on #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs in this: * The caches `BuilderWithOptions` defaulted the opts it got from the manager with the ones it explicitly got, resulting in new fields like `DefaultSelector` needing to explicitly be added there * The caches `DefaultSelector` wasn't correctly used everywhere, because there was code left that directly accessed the gvk -> selector map and thus didn't get the default selector. Use a getter func rather than the map internally, to make this impossible
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
vincepri
approved these changes
Dec 8, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two bugs in this:
BuilderWithOptionsdefaulted the opts it got from themanager with the ones it explicitly got, resulting in new fields
like
DefaultSelectorneeding to explicitly be added thereDefaultSelectorwasn't correctly used everywhere, becausethere was code left that directly accessed the gvk -> selector map and
thus didn't get the default selector. Use a getter func rather than
the map internally, to make this impossible
/assign @vincepri