Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken resource kind logging #1945

Closed
tatsuhiro-t opened this issue Jun 28, 2022 · 6 comments · Fixed by #1954
Closed

Broken resource kind logging #1945

tatsuhiro-t opened this issue Jun 28, 2022 · 6 comments · Fixed by #1954

Comments

@tatsuhiro-t
Copy link
Contributor

#1827 introduced this funny bug that kind is logged in unexpected way.

More specifically,

lowerCamelCaseKind := strings.ToLower(gvk.Kind[:1]) + gvk.Kind[1:]

If gvk.Kind is "APIService", I expect "apiService", but the current code produces and logs "aPIService".

@FillZpp
Copy link
Contributor

FillZpp commented Jun 29, 2022

That's interesting, but I'm not sure how can we convert to lower cases like this..

@tatsuhiro-t
Copy link
Contributor Author

tatsuhiro-t commented Jun 29, 2022

Why not just log kind as is? If key must start with a lower case letter, then make entire kind in lower case and log it.

@FillZpp
Copy link
Contributor

FillZpp commented Jun 29, 2022

Actually I don't think this line is necessary since the namespace and name will also be values.

@FillZpp
Copy link
Contributor

FillZpp commented Jun 29, 2022

@sbueringer WDYT

@tatsuhiro-t
Copy link
Contributor Author

I just went ahead and made #1954

@sbueringer
Copy link
Member

Missed this issue. I answered here: #1954 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants