Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Expose Cache/Client options on Cluster #2177

Merged
merged 1 commit into from Feb 7, 2023
Merged

✨ Expose Cache/Client options on Cluster #2177

merged 1 commit into from Feb 7, 2023

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Feb 3, 2023

Signed-off-by: Vince Prignano vincepri@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2023
@vincepri
Copy link
Member Author

vincepri commented Feb 3, 2023

/hold

for tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@vincepri
Copy link
Member Author

vincepri commented Feb 3, 2023

@alvaroaleman @sbueringer thoughts on the approach?

alvaroaleman
alvaroaleman reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot, much cleaner :)

pkg/cluster/cluster.go Outdated Show resolved Hide resolved
pkg/cluster/cluster.go Show resolved Hide resolved
@vincepri vincepri force-pushed the rework-cluster-options branch 4 times, most recently from 01f3b40 to 49d991d Compare February 6, 2023 15:51
@vincepri
Copy link
Member Author

vincepri commented Feb 6, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@vincepri
Expose Cache/Client options on Cluster
ed9c5ef 
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@sbueringer
Copy link
Member

Looks good to me

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f9d8abc into kubernetes-sigs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincepri @sbueringer @k8s-ci-robot @alvaroaleman