Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Provide more information on deprecating ComponentConfig #2200

Merged
merged 1 commit into from Feb 17, 2023
Merged

馃尡 Provide more information on deprecating ComponentConfig #2200

merged 1 commit into from Feb 17, 2023

Conversation

vincepri
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2023
@vincepri
Copy link
Member Author

/assign @alvaroaleman @sbueringer

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
@vincepri
Provide more information on deprecating ComponentConfig
15868a0 
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@vincepri vincepri force-pushed the fix-and-andfrom-deprecation-notice branch from 38b01e3 to 15868a0 Compare February 15, 2023 21:27
@FillZpp
Copy link
Contributor

FillZpp commented Feb 16, 2023

/lgtm
/hold
for other reviews

When do we plan to remove the ControllerManagerConfiguration?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@vincepri
Copy link
Member Author

@FillZpp We could aim for N+2 versions after the deprecation goes out?

@FillZpp
Copy link
Contributor

FillZpp commented Feb 17, 2023

@FillZpp We could aim for N+2 versions after the deprecation goes out?

Alright, sounds good!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit e2b265b into kubernetes-sigs:main Feb 17, 2023
@sbueringer
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@inteon inteon Awaiting requested review from inteon

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

@FillZpp FillZpp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vincepri @k8s-ci-robot @FillZpp @sbueringer @alvaroaleman