⚠️ Flatten fields in controller.Options

[alvaroaleman]

Currently, controller.Options embedds config.Controller. This makes its usage pretty annoying, to set MaxConcurrentReconciles for example, one has to do it like this:

controller.Options{config.Options{MaxConcurrentReconciles: 8}}

This makes it harder to find what options exist and causes a lot of churn for downstream consumers. Re-Define the fields from config.Controller in controller.Options instead to avoid that.

This also fixes some defaulting bugs where we wouldn't default MaxConcurrentReconciles and CacheSyncTimeout from the config.Controller setting in the manager.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/lgtm

/hold
because of #2307 (comment) (I think it can be a follow-up if we want to implement something)

[vincepri]

/hold cancel
/lgtm

[k8s-ci-robot]

@alvaroaleman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-apidiff	c1b8baf	link	false	/test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.