Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use NewRateLimitingQueueWithConfig instead of deprecated NewNamedRateLimitingQueue #2411

Merged

Conversation

sbueringer
Copy link
Member

Just moving away from the deprecated func. Behavior stays exactly the same

Fixes #2385

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2023
@sbueringer sbueringer changed the title Use NewRateLimitingQueueWithConfig instead of deprecated NewNamedRateLimitingQueue 🌱 Use NewRateLimitingQueueWithConfig instead of deprecated NewNamedRateLimitingQueue Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 283ebb6 into kubernetes-sigs:main Jul 18, 2023
11 of 12 checks passed
@sbueringer sbueringer deleted the pr-remove-deprecated-constructor branch July 18, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The work_queue in the controller should be replaced by a new construction method
3 participants